Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1522503002: [es6] Don't use the %GetPrototype runtime entry for super calls. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Don't use the %GetPrototype runtime entry for super calls. The %GetPrototype runtime function does a lot more than the GetSuperConstructor specified in ES6 12.3.5.2. So this introduces a proper %_GetSuperConstructor instead with support in TurboFan. R=jarin@chromium.org, rossberg@chromium.org Committed: https://crrev.com/c77c1ca80be4b2c98ef9a97751866a60a5b2015e Cr-Commit-Position: refs/heads/master@{#32804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years ago (2015-12-11 15:11:12 UTC) #1
rossberg
LGTM, but no test?
5 years ago (2015-12-11 15:15:09 UTC) #2
Benedikt Meurer
Well, there are already a lot of tests for the derived class stuff.
5 years ago (2015-12-11 15:28:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522503002/1
5 years ago (2015-12-11 15:28:57 UTC) #5
Jarin
lgtm
5 years ago (2015-12-11 15:33:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522503002/1
5 years ago (2015-12-11 15:33:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 15:48:52 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-11 15:49:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c77c1ca80be4b2c98ef9a97751866a60a5b2015e
Cr-Commit-Position: refs/heads/master@{#32804}

Powered by Google App Engine
This is Rietveld 408576698