Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1522473002: Reland addition of init function for asm->wasm. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland addition of init function for asm->wasm. This relands this, in it's new home: https://github.com/WebAssembly/v8-native-prototype/commit/032faa8a902f6555980e8848ca28208b0333d974 R=titzer@chromium.org BUG= Committed: https://crrev.com/ff0cc4a4c1e882fdb03937e2b696a5b566ac69bc Cr-Commit-Position: refs/heads/master@{#32798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -51 lines) Patch
M src/wasm/asm-wasm-builder.cc View 4 chunks +71 lines, -31 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +14 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bradn
5 years ago (2015-12-11 13:10:24 UTC) #2
titzer
On 2015/12/11 13:10:24, bradn wrote: lgtm
5 years ago (2015-12-11 13:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522473002/1
5 years ago (2015-12-11 13:51:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 14:09:23 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-11 14:10:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff0cc4a4c1e882fdb03937e2b696a5b566ac69bc
Cr-Commit-Position: refs/heads/master@{#32798}

Powered by Google App Engine
This is Rietveld 408576698