Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1522433004: eliminate code related to --no-ir-gen (Closed)

Created:
5 years ago by rkotlerimgtec
Modified:
5 years ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : fix makefiles to eliminate ALLOW_DISABLE_IR_GEN #

Total comments: 2

Patch Set 3 : changes suggested by stichnot #

Total comments: 8

Patch Set 4 : Changes suggested by stichnot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -326 lines) Patch
M CMakeLists.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Makefile View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Makefile.standalone View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/IceBuildDefs.h View 1 2 3 1 chunk +41 lines, -45 lines 0 comments Download
M src/IceClFlags.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/IceClFlags.cpp View 1 2 3 4 chunks +1 line, -8 lines 0 comments Download
M src/IceCompiler.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M src/IceConverter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/IceGlobalContext.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/IceOperand.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 2 45 chunks +25 lines, -171 lines 0 comments Download
M tests_lit/parse_errs/bad-bb-size.test View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/parse_errs/bad-global-alignment.test View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/parse_errs/bad-var-fwdref.test View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/parse_errs/duplicate-fcn-name.test View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/reader_tests/alloca.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/binops.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/branch.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/call.ll View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/reader_tests/casts.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/compare.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/constants.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/forwardref.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/globalinit.pnacl.ll View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/reader_tests/globalrelocs.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/insertextract.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/load.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/nacl-atomic-intrinsics.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/nacl-other-intrinsics.ll View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/reader_tests/phi.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/select.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/store.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/switch.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/unnamed.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/reader_tests/unreachable.ll View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
rkotlerimgtec
Checked this by inspection and ran make check. Have not so far run full tests ...
5 years ago (2015-12-12 03:08:30 UTC) #3
rkotlerimgtec
5 years ago (2015-12-12 04:09:33 UTC) #4
Jim Stichnoth
Once you make these further changes, you also need to remove -no-ir-gen from the various ...
5 years ago (2015-12-12 04:11:02 UTC) #5
Jim Stichnoth
https://codereview.chromium.org/1522433004/diff/20001/Makefile File Makefile (right): https://codereview.chromium.org/1522433004/diff/20001/Makefile#newcode24 Makefile:24: -DALLOW_LLVM_IR_AS_INPUT=0 \ Do the same for Makefile.standalone and CMakeLists.txt. ...
5 years ago (2015-12-12 04:14:01 UTC) #6
rkotlerimgtec
https://codereview.chromium.org/1522433004/diff/1/src/IceClFlags.cpp File src/IceClFlags.cpp (right): https://codereview.chromium.org/1522433004/diff/1/src/IceClFlags.cpp#newcode86 src/IceClFlags.cpp:86: cl::opt<bool> DisableIRGeneration("no-ir-gen", On 2015/12/12 04:11:02, stichnot wrote: > remove ...
5 years ago (2015-12-12 05:33:03 UTC) #7
Jim Stichnoth
https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h File src/IceBuildDefs.h (left): https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h#oldcode22 src/IceBuildDefs.h:22: constexpr bool disableIrGen() { return ALLOW_DISABLE_IR_GEN; } Rebase from ...
5 years ago (2015-12-12 15:43:42 UTC) #8
Jim Stichnoth
https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h File src/IceBuildDefs.h (left): https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h#oldcode22 src/IceBuildDefs.h:22: constexpr bool disableIrGen() { return ALLOW_DISABLE_IR_GEN; } On 2015/12/12 ...
5 years ago (2015-12-13 15:55:20 UTC) #9
rkotlerimgtec
I'm almost done making these changes. In case you are online now, do we really ...
5 years ago (2015-12-14 02:23:02 UTC) #10
rkotlerimgtec
https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h File src/IceBuildDefs.h (left): https://codereview.chromium.org/1522433004/diff/40001/src/IceBuildDefs.h#oldcode22 src/IceBuildDefs.h:22: constexpr bool disableIrGen() { return ALLOW_DISABLE_IR_GEN; } On 2015/12/12 ...
5 years ago (2015-12-14 03:12:12 UTC) #11
Jim Stichnoth
On 2015/12/14 02:23:02, rkotlerimgtec wrote: > I'm almost done making these changes. In case you ...
5 years ago (2015-12-14 05:09:45 UTC) #12
Jim Stichnoth
lgtm
5 years ago (2015-12-14 05:36:13 UTC) #13
Jim Stichnoth
5 years ago (2015-12-14 05:36:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0d4fc92b7a200524e6e1e49002fdde58438a1cfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698