Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: src/heap/mark-compact.cc

Issue 1522433002: [heap] Remove heap-local variable caching FLAG_concurrent_sweeping (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index fcc99c3b6bee028963e3692d9a4304073d7a9aa2..6750d02c0d7c737b33f0e443ea379ca0204a1df1 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -561,7 +561,7 @@ void MarkCompactCollector::SweepOrWaitUntilSweepingCompleted(Page* page) {
void MarkCompactCollector::SweepAndRefill(CompactionSpace* space) {
- if (heap()->concurrent_sweeping_enabled() && !IsSweepingCompleted()) {
+ if (FLAG_concurrent_sweeping && !IsSweepingCompleted()) {
SweepInParallel(heap()->paged_space(space->identity()), 0);
space->RefillFreeList();
}
@@ -573,13 +573,13 @@ void MarkCompactCollector::EnsureSweepingCompleted() {
// If sweeping is not completed or not running at all, we try to complete it
// here.
- if (!heap()->concurrent_sweeping_enabled() || !IsSweepingCompleted()) {
+ if (!FLAG_concurrent_sweeping || !IsSweepingCompleted()) {
SweepInParallel(heap()->paged_space(OLD_SPACE), 0);
SweepInParallel(heap()->paged_space(CODE_SPACE), 0);
SweepInParallel(heap()->paged_space(MAP_SPACE), 0);
}
- if (heap()->concurrent_sweeping_enabled()) {
+ if (FLAG_concurrent_sweeping) {
pending_sweeper_tasks_semaphore_.Wait();
pending_sweeper_tasks_semaphore_.Wait();
pending_sweeper_tasks_semaphore_.Wait();
@@ -3848,7 +3848,7 @@ void MarkCompactCollector::SweepSpaces() {
SweepSpace(heap()->map_space(), CONCURRENT_SWEEPING);
}
sweeping_in_progress_ = true;
- if (heap()->concurrent_sweeping_enabled()) {
+ if (FLAG_concurrent_sweeping) {
StartSweeperThreads();
}
}
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698