Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1522333003: Revert of [debugger] re-enable step in frame test. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] re-enable step in frame test. (patchset #1 id:1 of https://codereview.chromium.org/1518403004/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/4780/steps/Mjsunit/logs/debug-step-4-in-frame Original issue's description: > [debugger] re-enable step in frame test. > > Issue has long been fixed. > > R=jkummerow@chromium.org > BUG=v8:2921 > LOG=N > > Committed: https://crrev.com/f27105b17a23a64faeae33b939555840e388136e > Cr-Commit-Position: refs/heads/master@{#32862} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2921 Committed: https://crrev.com/a227a6b6ded635080663dac9336d29e9b10502e6 Cr-Commit-Position: refs/heads/master@{#32863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M test/mjsunit/debug-step-4-in-frame.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of [debugger] re-enable step in frame test.
5 years ago (2015-12-15 12:45:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522333003/1
5 years ago (2015-12-15 12:45:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 12:45:29 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-15 12:45:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a227a6b6ded635080663dac9336d29e9b10502e6
Cr-Commit-Position: refs/heads/master@{#32863}

Powered by Google App Engine
This is Rietveld 408576698