Bug Fix for Intel atan on gpu sweep gradient

Bug Fix for Intel atan on gpu sweep gradient

BUG=skia:2164
Committed: http://code.google.com/p/skia/source/detail?r=13456

[egdaniel, 2014-02-12 17:25:31]

Added check for Intel device in GPU sweep gradient to catch atan bug, and added
to vendor check in GrGLUtils to look for string starting with "Intel " or
exactly "Intel"

[bsalomon, 2014-02-12 22:14:37]

lgtm w/ comment about string compare function.

https://codereview.chromium.org/152233006/diff/20001/src/gpu/gl/GrGLUtil.cpp
File src/gpu/gl/GrGLUtil.cpp (right):

https://codereview.chromium.org/152233006/diff/20001/src/gpu/gl/GrGLUtil.cpp#...
src/gpu/gl/GrGLUtil.cpp:218: if (0 == vendorStringTmp.compare(0, 6, "Intel ") ||
0 == strcmp(vendorString, "Intel")) {
strncmp? Not totally opposed to std::string but since we're already using the
C-style str functions here it seems more consistent.

[egdaniel, 2014-02-13 14:43:16]

On 2014/02/12 22:14:37, bsalomon wrote:
> lgtm w/ comment about string compare function.
> 
> https://codereview.chromium.org/152233006/diff/20001/src/gpu/gl/GrGLUtil.cpp
> File src/gpu/gl/GrGLUtil.cpp (right):
> 
>
https://codereview.chromium.org/152233006/diff/20001/src/gpu/gl/GrGLUtil.cpp#...
> src/gpu/gl/GrGLUtil.cpp:218: if (0 == vendorStringTmp.compare(0, 6, "Intel ")
||
> 0 == strcmp(vendorString, "Intel")) {
> strncmp? Not totally opposed to std::string but since we're already using the
> C-style str functions here it seems more consistent.

Agreed. Changed to use strncmp.

[bsalomon, 2014-02-13 14:49:26]

lgtm

[egdaniel, 2014-02-14 14:12:25]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-02-14 14:12:35]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/egdaniel@google.com/152233006/80001

[commit-bot: I haz the power, 2014-02-14 17:27:06]

Change committed as 13456