Issue 152233002: android envsetup: Don't set mips_arch_variant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152233002: android envsetup: Don't set mips_arch_variant. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
Torne, paul.l...

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Don't set mips_arch_variant. Instead of the slightly rube-goldbergian approach of giving mips_arch_variant the default value mips32r2 in common.gypi and then always overriding this with mips32r1 in envsetup, just set mips_arch_variant to mips32r1 by default and don't set it in envsetup. I checked that the generated ninja file for base is identical before and after this change, and that the mips flags change as expected when manually setting mips_arch_variant to mips32r2. No behavior change. BUG=330631 TBR=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248409

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

6 years, 10 months ago (2014-02-02 16:10:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r248409 (presubmit successful).

Expand Messages | Collapse Messages