tools/telemetry/telemetry/internal/platform/android_platform_backend.py - Issue 1522313002: [Android] Move screenshot and video_recorder into devil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/android_platform_backend.py

Issue 1522313002: [Android] Move screenshot and video_recorder into devil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix video_recorder timing Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/video_recorder.py ('k') | tools/telemetry/telemetry/internal/platform/profiler/android_screen_recorder_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/internal/platform/android_platform_backend.py b/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

index 3d04be7aa672ae7f06b8c7cb0a371a2c039d34ef..7da73db70d664453d0ca78b2c370fe9c8962f5d5 100644

--- a/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

@@ -44,8 +44,8 @@ from devil.android.perf import cache_control

from devil.android.perf import perf_control

from devil.android.perf import thermal_throttle

from devil.android.sdk import version_codes

+from devil.android.tools import video_recorder

from pylib import constants

-from pylib import screenshot

try:

from devil.android.perf import surface_stats_collector

@@ -476,10 +476,9 @@ class AndroidPlatformBackend(

'Max capture rate is 100mbps.' % min_bitrate_mbps)

if self.is_video_capture_running:

self._video_recorder.Stop()

- self._video_recorder = screenshot.VideoRecorder(

+ self._video_recorder = video_recorder.VideoRecorder(

self._device, megabits_per_second=min_bitrate_mbps)

- self._video_recorder.Start()

- util.WaitFor(self._video_recorder.IsStarted, 5)

+ self._video_recorder.Start(timeout=5)

@property

def is_video_capture_running(self):