build/android/devil/android/device_utils.py - Issue 1522313002: [Android] Move screenshot and video_recorder into devil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1522313002: [Android] Move screenshot and video_recorder into devil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix video_recorder timing Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index ae794802ae96ae2883e3b908535b577463a61569..db9ae6fc5050e4cb58e539157e27ec0398003941 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -1891,7 +1891,8 @@ class DeviceUtils(object):

DeviceUnreachableError on missing device.

"""

if not host_path:

- host_path = os.path.abspath('screenshot-%s.png' % _GetTimeStamp())

+ host_path = os.path.abspath('screenshot-%s-%s.png' % (

+ self.adb.GetDeviceSerial(), _GetTimeStamp()))

with device_temp_file.DeviceTempFile(self.adb, suffix='.png') as device_tmp:

self.RunShellCommand(['/system/bin/screencap', '-p', device_tmp.name],

check_return=True)

« no previous file with comments | « build/android/devil/PRESUBMIT.py ('k') | build/android/devil/android/tools/__init__.py » ('j') | no next file with comments »