Enforce ordering in FilterTestNames.

build/util/lib/common/unittest_util.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utilities for dealing with the python unittest module."""
 
 import fnmatch
 import sys
 import unittest
 
@@ skipping 114 matching lines @@
     all_tests: List of test names.
     gtest_filter: Filter to apply.
 
   Returns:
     Filtered subset of the given list of test names.
   """
   pattern_groups = gtest_filter.split('-')
   positive_patterns = ['*']
   if pattern_groups[0]:
     positive_patterns = pattern_groups[0].split(':')
-  negative_patterns = None
+  negative_patterns = []
   if len(pattern_groups) > 1:
     negative_patterns = pattern_groups[1].split(':')
 
   tests = []
-  for test in all_tests:
-    # Test name must by matched by one positive pattern.
-    for pattern in positive_patterns:
-      if fnmatch.fnmatch(test, pattern):
-        break
-    else:
-      continue
-    # Test name must not be matched by any negative patterns.
-    for pattern in negative_patterns or []:
-      if fnmatch.fnmatch(test, pattern):
-        break
-    else:
-      tests += [test]
+  test_set = set()
+  for pattern in positive_patterns:
+    ptrn_tests = [test for test in all_tests

[mikecase (-- gone --), 2015/12/15 19:20:28]

nit: Would prefer if this was named pattern_tests

[alexandermont, 2015/12/15 19:37:53]

if you do this, it makes line 144 too long

[jbudorick, 2015/12/15 19:38:54]

I'd also prefer pattern_tests. You may need to handle line breaks a bit
differently.

+                  if (fnmatch.fnmatch(test, pattern) and
+                      not any(fnmatch(test, p) for p in negative_patterns) and
+                      test not in test_set)]
+    tests.extend(ptrn_tests)
+    test_set.update(ptrn_tests)
   return tests