Enforce ordering in FilterTestNames.

build/util/lib/common/unittest_util.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utilities for dealing with the python unittest module."""
 
 import fnmatch
 import sys
 import unittest
 
@@ skipping 114 matching lines @@
     all_tests: List of test names.
     gtest_filter: Filter to apply.
 
   Returns:
     Filtered subset of the given list of test names.
   """
   pattern_groups = gtest_filter.split('-')
   positive_patterns = ['*']
   if pattern_groups[0]:
     positive_patterns = pattern_groups[0].split(':')
-  negative_patterns = None
+  negative_patterns = []
   if len(pattern_groups) > 1:
     negative_patterns = pattern_groups[1].split(':')
 
   tests = []
-  for test in all_tests:
-    # Test name must by matched by one positive pattern.
-    for pattern in positive_patterns:
-      if fnmatch.fnmatch(test, pattern):
-        break
-    else:
-      continue
-    # Test name must not be matched by any negative patterns.
-    for pattern in negative_patterns or []:
-      if fnmatch.fnmatch(test, pattern):
-        break
-    else:
-      tests += [test]
+  for i in range(len(positive_patterns)):
+    pt_tests = [test for test in all_tests

[mikecase (-- gone --), 2015/12/15 16:32:20]

What does "pt" stand for?

+                if (fnmatch.fnmatch(test, positive_patterns[i]) and
+                    not any(fnmatch(test, p) for p in negative_patterns) and
+                    not any(fnmatch(test, p) for p in positive_patterns[:i]))]

[jbudorick, 2015/12/15 16:35:58]

I think you could make tests a set instead of a list while you're filtering and
remove this third any clause.

+    tests.extend(pt_tests)
   return tests