Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Issue 1522233002: Clamp legacy bisect param max_time_minutes to be in the range [1, 60]. (Closed)

Created:
5 years ago by qyearsley
Modified:
4 years, 12 months ago
Reviewers:
prasadv
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp legacy bisect param max_time_minutes to be in the range [1, 60]. BUG=569691 Committed: https://crrev.com/0866e86f0f42e3cd0c871bd498ce078479c3b620 Cr-Commit-Position: refs/heads/master@{#367022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/run-bisect-perf-regression.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
qyearsley
5 years ago (2015-12-14 22:17:54 UTC) #2
qyearsley
Ping
5 years ago (2015-12-21 18:59:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522233002/1
4 years, 12 months ago (2015-12-28 22:09:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 22:37:41 UTC) #7
prasadv
lgtm
4 years, 12 months ago (2015-12-28 22:55:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522233002/1
4 years, 12 months ago (2015-12-28 23:33:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 23:37:51 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 23:38:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0866e86f0f42e3cd0c871bd498ce078479c3b620
Cr-Commit-Position: refs/heads/master@{#367022}

Powered by Google App Engine
This is Rietveld 408576698