Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1522203002: Remove public dart:isolate dependency from dart:developer (Closed)

Created:
5 years ago by Cutch
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove public dart:isolate dependency from dart:developer - Move code from sdk/lib into runtime/lib. - Remove dependency on dart:isolate from dart:developer. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a1ed9c6d17d9c4b9363964d4b0e62992ed74db6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M runtime/lib/developer.dart View 2 chunks +79 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/developer/extension.dart View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
5 years ago (2015-12-14 21:24:33 UTC) #4
rmacnak
lgtm
5 years ago (2015-12-14 21:25:42 UTC) #5
Cutch
5 years ago (2015-12-14 21:26:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1ed9c6d17d9c4b9363964d4b0e62992ed74db6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698