Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590, 569198
Committed: https://crrev.com/9c7cbd939c735a69c551cfbf397f6cf707f8d22e
Cr-Commit-Position: refs/heads/master@{#366210}

[tommycli, 2015-12-14 20:23:51]

Patchset #2 (id:20001) has been deleted

[tommycli, 2015-12-14 21:17:55]

tommycli@chromium.org changed reviewers:
+ jam@chromium.org

[tommycli, 2015-12-14 21:17:56]

jam: PTAL, this is the fix we discussed on the bug. See below for an explanation
of why this adds a CHECK.

https://codereview.chromium.org/1522173002/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (right):

https://codereview.chromium.org/1522173002/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:277:
CHECK(plugin()->container());
The plugin / container semantics are kind-of under flux right now.

The other maintainers of the plugin code and I are sprinkling CHECKs within this
code until we suss out all the crashes (there are still a few more).

Once they are no longer needed we will change them to DCHECKs.

Other CHECKS:
https://code.google.com/p/chromium/codesearch#search/&q=loadable_plugin_place...

[tommycli, 2015-12-14 21:18:25]

Description was changed from

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

BUG=560590
==========

to

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

BUG=560590,569198
==========

[tommycli, 2015-12-16 01:42:15]

jam: ping, PS1 was the reverted patch, PS2 is the change that fixes the crash.

[tommycli, 2015-12-18 19:12:46]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2015-12-18 19:12:47]

thestig: PTAL. jam OOO, do you mind looking at the delta between PS1 and PS2 for
fixing this crash?

[Lei Zhang, 2015-12-18 21:59:07]

lgtm, TBR away.

[tommycli, 2015-12-18 22:25:21]

Description was changed from

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

BUG=560590,569198
==========

to

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590,569198
==========

[tommycli, 2015-12-18 22:25:34]

On 2015/12/18 21:59:07, Lei Zhang wrote:
> lgtm, TBR away.

thestig: thank you sir!

[tommycli, 2015-12-18 22:25:40]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-12-18 22:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522173002/40001

[commit-bot: I haz the power, 2015-12-18 23:34:42]

Description was changed from

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590,569198
==========

to

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590,569198
==========

[commit-bot: I haz the power, 2015-12-18 23:34:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-18 23:35:43]

Description was changed from

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590,569198
==========

to

==========
Reland: Plugin Power Saver: Improve Poster behavior for essential plugins.

Reland of https://codereview.chromium.org/1497623002/

TBR=

BUG=560590,569198

Committed: https://crrev.com/9c7cbd939c735a69c551cfbf397f6cf707f8d22e
Cr-Commit-Position: refs/heads/master@{#366210}
==========

[commit-bot: I haz the power, 2015-12-18 23:35:44]

Patchset 2 (id:??) landed as
https://crrev.com/9c7cbd939c735a69c551cfbf397f6cf707f8d22e
Cr-Commit-Position: refs/heads/master@{#366210}