Allow -webkit-text-decorations-in-effect preservation during para move.

Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html

Committed: https://crrev.com/19b906d239f014e4516f8dcce954c10da3415a6a
Cr-Commit-Position: refs/heads/master@{#366067}

[sof, 2015-12-15 06:22:47]

sigbjornf@opera.com changed reviewers:
+ hajimehoshi@chromium.org, tkent@chromium.org

[sof, 2015-12-15 06:22:48]

please take a look.

[tkent, 2015-12-15 06:36:19]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2015-12-15 06:36:19]

+yosin though he is ooo.

[sof, 2015-12-17 06:39:46]

No one else that looks after editing/ in the meantime?

[tkent, 2015-12-18 00:17:35]

Well, I'm not sure if this change is correct. However this is just for an ASSERT
change and won't affect production.  So, it's ok to land.  lgtm.

yosin@, please review this when you're available.

[sof, 2015-12-18 08:13:08]

On 2015/12/18 00:17:35, tkent wrote:
> Well, I'm not sure if this change is correct. However this is just for an
ASSERT
> change and won't affect production.  So, it's ok to land.  lgtm.
> 
> yosin@, please review this when you're available.

thanks, it merely looks like an imprecise assert introduced on this code path
during code refactoring, nothing more.

(Us at opera feel bad about yosin@ being perpetually swamped with editing/
issues.. so try to take care of stuff being reported once in a while, rather
than blanket reassign.)

[sof, 2015-12-18 08:13:24]

Description was changed from

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html
==========

to

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html
==========

[sof, 2015-12-18 08:14:26]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-12-18 08:14:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522063002/1

[commit-bot: I haz the power, 2015-12-18 09:47:11]

Description was changed from

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html
==========

to

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html
==========

[commit-bot: I haz the power, 2015-12-18 09:47:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-18 09:48:26]

Description was changed from

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html
==========

to

==========
Allow -webkit-text-decorations-in-effect preservation during para move.

Adjust assert to allow it; moving paragraphs as part of performing
JustifyRight will want to preserve styles, but this is done without
extra annotation. For which -webkit-text-decorations-in-effect is
also preserved.

R=tkent
BUG=498130
TEST=editing/execCommand/justify-right-in-effect-crash.html

Committed: https://crrev.com/19b906d239f014e4516f8dcce954c10da3415a6a
Cr-Commit-Position: refs/heads/master@{#366067}
==========

[commit-bot: I haz the power, 2015-12-18 09:48:27]

Patchset 1 (id:??) landed as
https://crrev.com/19b906d239f014e4516f8dcce954c10da3415a6a
Cr-Commit-Position: refs/heads/master@{#366067}