Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1522003003: suppress all dart contributor suggestions in comments (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -28 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +74 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-14 20:25:35 UTC) #2
scheglov
LGTM
5 years ago (2015-12-14 20:37:22 UTC) #3
danrubel
5 years ago (2015-12-14 23:50:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8a99902b9499e3ba60566dfdd2e115594c55c480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698