Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1521993008: Teach Chromium on Windows where to find Ogham glyphs (Closed)

Created:
5 years ago by Daniel Bratell
Modified:
5 years ago
Reviewers:
drott
CC:
chromium-reviews, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, krit, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach Chromium on Windows where to find Ogham glyphs Ogham glyphs are found in Segoe UI Symbol. BUG=569938 R=drott@chromium.org Committed: https://crrev.com/73a178bda739c022e3d2ecd79f1c2c1e3e574aa6 Cr-Commit-Position: refs/heads/master@{#366616}

Patch Set 1 #

Patch Set 2 : Adapted tests after Tifinagh feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/layout-fonts/ogham.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/inspector-protocol/layout-fonts/ogham-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Daniel Bratell
drott, please take a look. I did another of the unsupported scripts. This looks a ...
5 years ago (2015-12-22 13:45:13 UTC) #2
drott
LGTM, please fix the typo in commit msg before landing: Segoa = Segoe. Long term, ...
5 years ago (2015-12-22 14:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521993008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521993008/20001
5 years ago (2015-12-22 15:02:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 18:10:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-22 18:11:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73a178bda739c022e3d2ecd79f1c2c1e3e574aa6
Cr-Commit-Position: refs/heads/master@{#366616}

Powered by Google App Engine
This is Rietveld 408576698