Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1521993004: Move Object.observe back to shipping temporarily (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move Object.observe back to shipping temporarily Turning it off broke both the trace viewer and using the devtools to connect to an earlier version of Chrome running on another device. BUG=chromium:552100, chromium:569417, chromium:569647 TBR=rossberg@chromium.org LOG=y Committed: https://chromium.googlesource.com/v8/v8/+/9a97e7231f7adaa68fbb95870c9917986235a8b4

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521993004/1
5 years ago (2015-12-14 21:20:18 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/11445) v8_linux64_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-14 21:21:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521993004/20001
5 years ago (2015-12-14 21:35:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11490)
5 years ago (2015-12-14 22:06:52 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9a97e7231f7adaa68fbb95870c9917986235a8b4 Cr-Commit-Position: refs/heads/master@{#32850}
5 years ago (2015-12-15 05:58:25 UTC) #11
adamk
5 years ago (2015-12-15 05:58:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a97e7231f7adaa68fbb95870c9917986235a8b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698