Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1521963003: Couple comment tweaks for summaries IDL. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/analyzer/tool/summary/idl.dart View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
5 years ago (2015-12-15 06:12:09 UTC) #1
scheglov
https://codereview.chromium.org/1521963003/diff/1/pkg/analyzer/tool/summary/idl.dart File pkg/analyzer/tool/summary/idl.dart (right): https://codereview.chromium.org/1521963003/diff/1/pkg/analyzer/tool/summary/idl.dart#newcode644 pkg/analyzer/tool/summary/idl.dart:644: * into [UnlinkedLibrary.units]. This comment also does not look ...
5 years ago (2015-12-15 06:23:33 UTC) #2
Paul Berry
lgtm, thanks! https://codereview.chromium.org/1521963003/diff/1/pkg/analyzer/tool/summary/idl.dart File pkg/analyzer/tool/summary/idl.dart (right): https://codereview.chromium.org/1521963003/diff/1/pkg/analyzer/tool/summary/idl.dart#newcode644 pkg/analyzer/tool/summary/idl.dart:644: * into [UnlinkedLibrary.units]. On 2015/12/15 06:23:33, scheglov ...
5 years ago (2015-12-15 17:35:32 UTC) #3
scheglov
5 years ago (2015-12-15 17:52:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db1bf5fecfca46fd928f43aa1659d314c176561f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698