Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1521953003:
[debugger] correctly find source position of implicit return statement. (Closed)
|
Created:
5 years ago by Yang Modified:
5 years ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[debugger] correctly find source position of implicit return statement.
The parser reads one character beyond EOF to have an additional source
position that the rewriter can use to insert the implicit return
statement at the end of a script. If we break at that return statement,
we need to be able to translate the source position to line and
column number.
R=jkummerow@chromium.org
BUG=chromium:569514
LOG=N
Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28
Cr-Commit-Position: refs/heads/master@{#32825}
Committed: https://crrev.com/fd781bcc84c2a37b8bc54368b160cca0c74a47bd
Cr-Commit-Position: refs/heads/master@{#32835}
Patch Set 1 #Patch Set 2 : reland #
Messages
Total messages: 30 (15 generated)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521953003/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521953003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1526583002/ by yangguo@chromium.org. The reason for reverting is: Layout test failures: https://chromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Mac/buil....
Message was sent while issue was closed.
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ==========
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521953003/20001
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8912)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521953003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8917)
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ==========
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1521953003/#ps20001 (title: "reland")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521953003/20001
Message was sent while issue was closed.
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} ========== to ========== [debugger] correctly find source position of implicit return statement. The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} Committed: https://crrev.com/fd781bcc84c2a37b8bc54368b160cca0c74a47bd Cr-Commit-Position: refs/heads/master@{#32835} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fd781bcc84c2a37b8bc54368b160cca0c74a47bd Cr-Commit-Position: refs/heads/master@{#32835} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
