Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 1521943002: Use iframe in blink_perf.pywebsocket perf tests to remove --disable-web-security (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated DEPS. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/PerformanceTests/Pywebsocket/resources/util_performance_test.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index 76c64e8c662344f899ea0b999c7a8bbbad3136d3..9d43fdccecb00ad8703eb2ce3ff19d071d75fe82 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -125,15 +125,6 @@ class _BlinkPerfFullFrameMeasurement(_BlinkPerfMeasurement):
options.AppendExtraBrowserArgs(['--expose-internals-for-testing'])
-class _BlinkPerfPywebsocketMeasurement(_BlinkPerfMeasurement):
- def CustomizeBrowserOptions(self, options):
- super(_BlinkPerfPywebsocketMeasurement, self).CustomizeBrowserOptions(
- options)
- # Cross-origin accesses are needed to run benchmarks spanning two servers,
- # the Telemetry's HTTP server and the pywebsocket server.
- options.AppendExtraBrowserArgs(['--disable-web-security'])
-
-
class _SharedPywebsocketPageState(shared_page_state.SharedPageState):
"""Runs a pywebsocket server."""
def __init__(self, test, finder_options, user_story_set):
@@ -341,7 +332,7 @@ class BlinkPerfPywebsocket(perf_benchmark.PerfBenchmark):
regressions are often unreproducible (https://crbug.com/549017).
'''
tag = 'pywebsocket'
- test = _BlinkPerfPywebsocketMeasurement
+ test = _BlinkPerfMeasurement
@classmethod
def Name(cls):
« no previous file with comments | « third_party/WebKit/PerformanceTests/Pywebsocket/resources/util_performance_test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698