Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1521943002: Use iframe in blink_perf.pywebsocket perf tests to remove --disable-web-security (Closed)

Created:
5 years ago by hiroshige
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use iframe in blink_perf.pywebsocket perf tests to remove --disable-web-security Previously: (a) util_performance_test.js in Blink runs performance tests using (b) pywebsocket's scripts, but this required --disable-web-security for cross-origin workers because (a) and (b) have different origins. We change this so that: (a) util_performance_test.js creates (c) <iframe> with src=pywebsocket's example/*_iframe.html that runs the performance tests on the iframe using (b) pywebsocket's scripts. Because (b) and (c) have the same origin (but (a) has a different origin), Tests are run in the same-origin while we have an cross-origin iframe. This CL adds pywebsocket-side iframe HTML/JavaScript files for (b) and (c). and updates DEPS to include pywebsocket-side changes [1]. [1] pywebsocket-side: https://github.com/google/pywebsocket/pull/147 [2] Chromium-side: This CL. BUG=567533 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect Committed: https://crrev.com/76efe99397c323d99ba95a3eb0102207358aeb29 Cr-Commit-Position: refs/heads/master@{#365787}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Updated DEPS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -144 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/WebSocket-receive-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/WebSocket-receive-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-arraybuffer-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-arraybuffer-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-arraybuffer-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-blob-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-blob-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-blob-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-text-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-text-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-receive-text-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-arraybuffer-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-arraybuffer-window-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-arraybuffer-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-arraybuffer-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-blob-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-blob-window-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-blob-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-blob-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-text-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-text-window-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-text-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/XHR-send-text-worker-sync-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-arraybuffer-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-arraybuffer-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-blob-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-blob-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-text-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-receive-text-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-arraybuffer-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-arraybuffer-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-blob-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-blob-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-text-window-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/fetch-send-text-worker-async-verify.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/resources/generate.py View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Pywebsocket/resources/util_performance_test.js View 1 1 chunk +42 lines, -58 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
hiroshige
tyoshino@, could you take a look also at this Chromium/Blink-side CL? sullivan@, could you take ...
5 years ago (2015-12-15 07:05:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521943002/40001
5 years ago (2015-12-15 07:19:21 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/110752)
5 years ago (2015-12-15 09:45:35 UTC) #9
sullivan
lgtm Any idea if there is any work on iframe prioritization/throttling that could affect the ...
5 years ago (2015-12-15 22:13:22 UTC) #10
hiroshige
> Any idea if there is any work on iframe prioritization/throttling that could > affect ...
5 years ago (2015-12-16 07:19:44 UTC) #11
sullivan
On 2015/12/16 07:19:44, hiroshige wrote: > > Any idea if there is any work on ...
5 years ago (2015-12-16 15:23:27 UTC) #12
tyoshino (SeeGerritForStatus)
lgtm
5 years ago (2015-12-17 04:55:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521943002/40001
5 years ago (2015-12-17 06:35:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521943002/40001
5 years ago (2015-12-17 06:39:23 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 08:46:58 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-17 08:47:49 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76efe99397c323d99ba95a3eb0102207358aeb29
Cr-Commit-Position: refs/heads/master@{#365787}

Powered by Google App Engine
This is Rietveld 408576698