Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1521913005:
Add link to Gold trybot runs in every uploaded Skia CL (Closed)
DescriptionAdd link to Gold trybot runs in every uploaded Skia CL
BUG=skia:4433
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005
Committed: https://skia.googlesource.com/skia/+/11f457e1627be775cfa26d71307dbd6073f9269c
Patch Set 1 : Complete #Patch Set 2 : Document + Cleanup #Patch Set 3 : Lint fix #Messages
Total messages: 31 (26 generated)
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_LINK= https://gold.skia.org/search2?issue=1526523003&unt=true&query=source_type%3Dg... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_LINK= https://gold.skia.org/search2?issue=1526523003&unt=true&query=source_type%3Dg... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL=https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005 ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL=https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005 ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= <a href="https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005">here</a> ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= <a href="https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005">here</a> ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia:4433 ==========
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia:4433 ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia:4433 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
rmistry@google.com changed reviewers: + mtklein@google.com, stephana@google.com
The context for this CL is that Mike yesterday asked for a link in the CL's description that pointed to Gold. Look at the description of this CL for what it will look like. Let me know if you have any alternate suggestions.
lgtm
On 2015/12/15 13:45:16, mtklein wrote: > lgtm lgtm
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521913005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521913005/160001
Message was sent while issue was closed.
Description was changed from ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia:4433 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add link to Gold trybot runs in every uploaded Skia CL BUG=skia:4433 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/11f457e1627be775cfa26d71307dbd6073f9269c ==========
Message was sent while issue was closed.
Committed patchset #3 (id:160001) as https://skia.googlesource.com/skia/+/11f457e1627be775cfa26d71307dbd6073f9269c |
