Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 15219003: Move updateLayout() call from RenderLayer to RenderView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index b8d95604b2f9de2f46442a8ac8140a6510c85fb6..6e3069a4bbad4073a32175661ddfe7a42b270595 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -4344,8 +4344,10 @@ bool RenderLayer::hitTest(const HitTestRequest& request, const HitTestLocation&
{
ASSERT(isSelfPaintingLayer() || hasSelfPaintingLayerDescendant());
- renderer()->document()->updateLayout();
-
+ // RenderView should make sure to update layout before entering hit testing
+ ASSERT(!renderer()->frame()->view()->layoutPending());
+ ASSERT(!renderer()->document()->renderer()->needsLayout());
+
LayoutRect hitTestArea = isOutOfFlowRenderFlowThread() ? toRenderFlowThread(renderer())->borderBoxRect() : renderer()->view()->documentRect();
if (!request.ignoreClipping())
hitTestArea.intersect(frameVisibleRect(renderer()));

Powered by Google App Engine
This is Rietveld 408576698