Move updateLayout() call from RenderLayer to RenderView

Source/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 69 matching lines @@
 {
 }
 
 bool RenderView::hitTest(const HitTestRequest& request, HitTestResult& result)
 {
     return hitTest(request, result.hitTestLocation(), result);
 }
 
 bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& location, HitTestResult& result)
 {
+    // We have to recursively update layout/style here because otherwise, when the hit test recurses
+    // into a child document, it could trigger a layout on the parent document, which can destroy RenderLayers

[ojan, 2013/05/16 23:57:54]

When does hit-testing in a child document trigger a layout in the parent
document? I expect this code is right, I just want to understand the codepath
that requires the recursive bit before lgtm'ing.

[cbiesinger, 2013/05/17 00:17:04]

Document::updateLayout calls updateLayout on its parent:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

But now that you ask, I don't fully understand why that is a problem... I think
I need to spend more time in gdb.

+    // that are higher up in the call stack, leading to crashes.
+    frameView()->updateLayoutAndStyleIfNeededRecursive();
     return layer()->hitTest(request, location, result);
 }
 
 void RenderView::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit, LogicalExtentComputedValues& computedValues) const
 {
     computedValues.m_extent = (!shouldUsePrintingLayout() && m_frameView) ? LayoutUnit(viewLogicalHeight()) : logicalHeight;
 }
 
 void RenderView::updateLogicalWidth()
 {
@@ skipping 1055 matching lines @@
 #endif
 
     if (layoutState)
         layoutState->m_isPaginated = m_fragmenting;
         
     if (m_flowThreadState != RenderObject::NotInsideFlowThread)
         m_root->setFlowThreadStateIncludingDescendants(m_flowThreadState);
 }
 
 } // namespace WebCore