Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1521883002: Fix lints: unnecessary_brace_in_string_interp (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix lints: unnecessary_brace_in_string_interp Also fixes two cases of empty_constructor_bodies. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2f0f398c737288b56e9dee3232c60ec5cf7e706b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -68 lines) Patch
M pkg/analysis_server/benchmark/perf/completion_timing_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/refactoring/refactoring_core.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/average.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 15 chunks +27 lines, -27 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-13 18:41:43 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-13 18:53:31 UTC) #2
scheglov
5 years ago (2015-12-13 21:05:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2f0f398c737288b56e9dee3232c60ec5cf7e706b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698