Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1521843002: GN: Build PPAPI extensions tests (Closed)

Created:
5 years ago by Petr Hosek
Modified:
5 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Build PPAPI extensions tests PPAPI extensions tests use the same structure as NaCl browser tests and as such can use the same template which was refactored and moved to a .gni file which is now used by both types of tests. BUG=462791, 512900 Committed: https://crrev.com/b460625d15a1ea80272d125a63233d823d095a1d Cr-Commit-Position: refs/heads/master@{#365369}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Handle both debug and nonstable pexe options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -251 lines) Patch
M build/config/nacl/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M chrome/test/data/nacl/BUILD.gn View 1 2 29 chunks +59 lines, -246 lines 0 comments Download
A ppapi/native_client/nacl_test_data.gni View 1 2 1 chunk +264 lines, -0 lines 0 comments Download
A ppapi/tests/extensions/BUILD.gn View 1 chunk +269 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
Petr Hosek
These are the last NaCl tests which need to be converted from GYP to GN.
5 years ago (2015-12-12 22:47:57 UTC) #4
bradn
lgtm
5 years ago (2015-12-14 09:10:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521843002/1
5 years ago (2015-12-14 09:11:02 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-14 09:11:04 UTC) #11
bradnelson
lgtm
5 years ago (2015-12-14 09:11:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521843002/1
5 years ago (2015-12-14 09:12:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/128498)
5 years ago (2015-12-14 09:19:31 UTC) #16
bbudge
Rubber stamp lgtm
5 years ago (2015-12-14 18:50:37 UTC) #17
Dirk Pranke
lgtm
5 years ago (2015-12-14 21:09:09 UTC) #18
Petr Hosek
Pawel, would it be possible to do an OWNERS review for chrome/test/*?
5 years ago (2015-12-14 22:33:19 UTC) #20
Paweł Hajdan Jr.
LGTM
5 years ago (2015-12-15 11:16:57 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521843002/40001
5 years ago (2015-12-15 22:38:47 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 23:00:42 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-15 23:02:28 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b460625d15a1ea80272d125a63233d823d095a1d
Cr-Commit-Position: refs/heads/master@{#365369}

Powered by Google App Engine
This is Rietveld 408576698