impl/prod/raw_datastore.go - Issue 1521823003: Clean up callback interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/prod/raw_datastore.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra

Patch Set: fixins Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/prod/raw_datastore.go

diff --git a/impl/prod/raw_datastore.go b/impl/prod/raw_datastore.go

index e70b31adb06670de9cbcdab4a238626571dbcb8b..2353818040022f93afbc61bbd8c08c7c02a6d425 100644

--- a/impl/prod/raw_datastore.go

+++ b/impl/prod/raw_datastore.go

@@ -216,8 +216,11 @@ func (d rdsImpl) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {

if err != nil {

return err

}

- if !cb(dsR2F(k), tf.pm, cfunc) {

- return nil

+ if err := cb(dsR2F(k), tf.pm, cfunc); err != nil {

+ if err == ds.Stop {

+ return nil

+ }

+ return err

}

« no previous file with comments | « impl/prod/everything_test.go ('k') | service/datastore/checkfilter_test.go » ('j') | no next file with comments »