Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: filter/txnBuf/txnbuf_test.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra
Patch Set: fixins Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/txnBuf/state.go ('k') | impl/memory/datastore_data.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/txnBuf/txnbuf_test.go
diff --git a/filter/txnBuf/txnbuf_test.go b/filter/txnBuf/txnbuf_test.go
index 62ecba2d03d3a316a821d0327e2e357d4aac88bb..d027ed331f39fb669740434e3bbed0dc64b6874f 100644
--- a/filter/txnBuf/txnbuf_test.go
+++ b/filter/txnBuf/txnbuf_test.go
@@ -856,20 +856,18 @@ func TestQuerySupport(t *testing.T) {
ds := datastore.Get(c)
q := datastore.NewQuery("Foo").Ancestor(root)
- return ds.Run(q, func(pm datastore.PropertyMap, _ datastore.CursorCB) bool {
+ return ds.Run(q, func(pm datastore.PropertyMap) {
So(ds.RunInTransaction(func(c context.Context) error {
ds := datastore.Get(c)
pm["Value"] = append(pm["Value"], datastore.MkProperty("wat"))
return ds.Put(pm)
}, nil), ShouldBeNil)
- return true
})
}, &datastore.TransactionOptions{XG: true}), ShouldBeNil)
- So(ds.Run(datastore.NewQuery("Foo"), func(pm datastore.PropertyMap, _ datastore.CursorCB) bool {
+ So(ds.Run(datastore.NewQuery("Foo"), func(pm datastore.PropertyMap) {
val := pm["Value"]
So(val[len(val)-1].Value(), ShouldResemble, "wat")
- return true
}), ShouldBeNil)
})
« no previous file with comments | « filter/txnBuf/state.go ('k') | impl/memory/datastore_data.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698