Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: filter/txnBuf/ds_txn.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra
Patch Set: fixins Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/txnBuf/query_merger.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/txnBuf/ds_txn.go
diff --git a/filter/txnBuf/ds_txn.go b/filter/txnBuf/ds_txn.go
index b04f354f9068050a76db763e9867a9bdec75acf4..bc72eae5d374fd8ab089d53cebfecefe825ddc53 100644
--- a/filter/txnBuf/ds_txn.go
+++ b/filter/txnBuf/ds_txn.go
@@ -58,9 +58,9 @@ func (d *dsTxnBuf) Count(fq *ds.FinalizedQuery) (count int64, err error) {
return
}
}
- err = d.Run(fq, func(_ *ds.Key, _ ds.PropertyMap, _ ds.CursorCB) bool {
+ err = d.Run(fq, func(_ *ds.Key, _ ds.PropertyMap, _ ds.CursorCB) error {
count++
- return true
+ return nil
})
return
}
@@ -84,14 +84,14 @@ func (d *dsTxnBuf) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {
return d.state.bufDS, d.state.parentDS, d.state.entState.dup()
}()
- return runMergedQueries(fq, sizes, bufDS, parentDS, func(key *ds.Key, data ds.PropertyMap) bool {
+ return runMergedQueries(fq, sizes, bufDS, parentDS, func(key *ds.Key, data ds.PropertyMap) error {
if offset > 0 {
offset--
- return true
+ return nil
}
if limitSet {
if limit == 0 {
- return false
+ return ds.Stop
}
limit--
}
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/txnBuf/query_merger.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698