Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: filter/dscache/ds.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra
Patch Set: fixins Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | filter/txnBuf/ds_txn.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/dscache/ds.go
diff --git a/filter/dscache/ds.go b/filter/dscache/ds.go
index 910727fe7d4d1d7d294d0e15f01afffdfc5ec993..47586d8a309c5901c0fdec70dfadbf29f9e527b2 100644
--- a/filter/dscache/ds.go
+++ b/filter/dscache/ds.go
@@ -57,7 +57,7 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu
toCas := []memcache.Item{}
j := 0
- err := d.RawInterface.GetMulti(p.toGet, p.toGetMeta, func(pm ds.PropertyMap, err error) {
+ err := d.RawInterface.GetMulti(p.toGet, p.toGetMeta, func(pm ds.PropertyMap, err error) error {
i := p.idxMap[j]
toSave := p.toSave[j]
j++
@@ -81,7 +81,7 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu
} else {
p.lme.Assign(i, err)
if err != ds.ErrNoSuchEntity {
- return // aka continue to the next entry
+ return nil // aka continue to the next entry
}
}
@@ -101,6 +101,7 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu
}
toCas = append(toCas, toSave)
}
+ return nil
})
if err != nil {
return err
« no previous file with comments | « no previous file | filter/txnBuf/ds_txn.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698