Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: impl/memory/datastore_test.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/memory/datastore_query_execution_test.go ('k') | impl/memory/gkvlite_iter.go » ('j') | impl/memory/gkvlite_iter.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/memory/datastore_test.go
diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go
index 269b5dea2100fd48e4e06137a341bf57dad8f742..2f22e3dedc72c2fee1e1de93ec3cff256c3eeada 100644
--- a/impl/memory/datastore_test.go
+++ b/impl/memory/datastore_test.go
@@ -100,9 +100,10 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
}
So(ds.DeleteMulti(keys), ShouldBeNil)
count := 0
- So(ds.Raw().DeleteMulti(keys, func(err error) {
+ So(ds.Raw().DeleteMulti(keys, func(err error) error {
count++
So(err, ShouldBeNil)
+ return nil
}), ShouldBeNil)
So(count, ShouldEqual, len(keys))
})
@@ -129,9 +130,8 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
ds.Testable().CatchupIndexes()
count := 0
- So(ds.Run(dsS.NewQuery(""), func(_ *dsS.Key, _ dsS.CursorCB) bool {
+ So(ds.Run(dsS.NewQuery(""), func(_ *dsS.Key) {
count++
- return true
}), ShouldBeNil)
So(count, ShouldEqual, 3)
« no previous file with comments | « impl/memory/datastore_query_execution_test.go ('k') | impl/memory/gkvlite_iter.go » ('j') | impl/memory/gkvlite_iter.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698