Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1521803002: Match WebUSB errors more closely to the specificiation. (Closed)

Created:
5 years ago by Reilly Grant (use Gerrit)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match WebUSB errors more closely to the specificiation. This change updates USBError to generate the set of DOMExceptions used in the WebUSB specification and updates WebUSBClientImpl and WebUSBDeviceImpl to generate them where possible. At this point accurate errors are limited by the granularity of the results returned by the Mojo interface. BUG=492204 Committed: https://crrev.com/e708cef743e4245064bafb701cf78a97106fa59a Cr-Commit-Position: refs/heads/master@{#365209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M content/renderer/usb/web_usb_client_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 5 chunks +18 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBError.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/modules/webusb/WebUSBError.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years ago (2015-12-12 02:18:26 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years ago (2015-12-14 17:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521803002/1
5 years ago (2015-12-15 01:22:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on ...
5 years ago (2015-12-15 04:20:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521803002/1
5 years ago (2015-12-15 08:12:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 08:22:01 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-15 08:22:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e708cef743e4245064bafb701cf78a97106fa59a
Cr-Commit-Position: refs/heads/master@{#365209}

Powered by Google App Engine
This is Rietveld 408576698