Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 15218004: GeneratorFunction() makes generator instances (Closed)

Created:
7 years, 7 months ago by wingo
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

GeneratorFunction() makes generator instances The current specification has GeneratorFunction() be like Function(), except that it makes generator instances. This commit implements that behavior. It also fills in a piece of the implementation where otherwise calling GeneratorFunction or GeneratorFunctionPrototype would cause an abort because they have no code. R=mstarzinger@chromium.org TEST=mjsunit/harmony/generators-iteration TEST=mjsunit/harmony/generators-runtime BUG=v8:2355, v8:2680 Committed: http://code.google.com/p/v8/source/detail?r=15084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -10 lines) Patch
M src/generator.js View 2 chunks +19 lines, -0 lines 0 comments Download
M src/v8natives.js View 2 chunks +16 lines, -10 lines 0 comments Download
M test/mjsunit/harmony/generators-iteration.js View 1 chunk +22 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/generators-runtime.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
This is another attempt to land https://codereview.chromium.org/14857009/, this time making it so that SyntaxErrors are ...
7 years, 7 months ago (2013-05-16 09:45:26 UTC) #1
Michael Starzinger
LGTM.
7 years, 7 months ago (2013-05-23 08:32:11 UTC) #2
wingo
I had wanted to wait until the WebKit bot was green, but as discussed offline ...
7 years, 6 months ago (2013-06-12 12:47:25 UTC) #3
wingo
7 years, 6 months ago (2013-06-12 12:52:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698