Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1521753002: extract LocalConstructorContributor from local reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index 663acf3bf765f5a2c55baab78a64c6b67db4ea0f..3fd76871df1d537f048a1bbf65b5f5692082c846 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -664,11 +664,6 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
return assertNotSuggested(name);
}
- CompletionSuggestion assertSuggestLocalConstructor(String name,
- {int elemOffset}) {
- return assertNotSuggested(name);
- }
-
CompletionSuggestion assertSuggestLocalField(String name, String type,
{int relevance: DART_RELEVANCE_LOCAL_FIELD, bool deprecated: false}) {
return assertNotSuggested(name);
@@ -3026,8 +3021,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
assertSuggestImportedConstructor('Object');
assertSuggestImportedConstructor('Future');
assertSuggestImportedConstructor('A');
- assertSuggestLocalConstructor('B');
- assertSuggestLocalConstructor('C');
+ // Suggested by ConstructorContributor
+ assertNotSuggested('B');
+ assertNotSuggested('C');
assertNotSuggested('f');
assertNotSuggested('x');
assertNotSuggested('foo');
@@ -3752,7 +3748,8 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
return computeFull((bool result) {
expect(request.replacementOffset, completionOffset);
expect(request.replacementLength, 0);
- assertSuggestLocalConstructor('B.bar');
+ // Suggested by ConstructorContributor
+ assertNotSuggested('B.bar');
assertSuggestImportedConstructor('Object');
assertSuggestImportedConstructor('X.c');
assertNotSuggested('X._d');
@@ -3790,7 +3787,8 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
return computeFull((bool result) {
expect(request.replacementOffset, completionOffset);
expect(request.replacementLength, 0);
- assertSuggestLocalConstructor('A');
+ // Suggested by ConstructorContributor
+ assertNotSuggested('A');
assertSuggestImportedConstructor('Object');
assertSuggestImportedConstructor('X.c');
assertNotSuggested('X._d');

Powered by Google App Engine
This is Rietveld 408576698