Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1521733002: Enabling Touch input mode on the Android client. (Closed)

Created:
5 years ago by joedow
Modified:
5 years ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabling Touch input mode on the Android client. Now that the SimulatedTouchInputStrategy change has landed, all of the pieces for this work are checked in, we can remove the line of code which was keeping the feature disabled. NOTE: I do have one more change to add an InputStrategy which handles remote input for touch enabled hosts but that is not required in order for us to turn this on now. BUG=454549 Committed: https://crrev.com/74ac2e98983eb4e4d186e9891aa6901c96458c17 Cr-Commit-Position: refs/heads/master@{#364881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joedow
This change enables the Touch input mode toggle UX. My earlier change with the SimulatedTouchINputStrategy ...
5 years ago (2015-12-12 00:16:09 UTC) #2
Lambros
lgtm
5 years ago (2015-12-12 00:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521733002/1
5 years ago (2015-12-12 02:26:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 03:41:04 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-12 03:42:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74ac2e98983eb4e4d186e9891aa6901c96458c17
Cr-Commit-Position: refs/heads/master@{#364881}

Powered by Google App Engine
This is Rietveld 408576698