Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 152173002: android envsetup: If ANDROID_SDK_ROOT is set, honor it unconditionally. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android envsetup: If ANDROID_SDK_ROOT is set, honor it unconditionally. If this patch breaks your build, try running `unset ANDROID_SDK_ROOT`. Before this patch, envsetup checked if ${ANDROID_SDK_ROOT}/platforms/android-${ANDROID_SDK_VERSION} existed and fell back to the sdk in chromium's third_party if that wasn't the case. Since most people don't set ANDROID_SDK_ROOT and the ones who do will be able to realize that they're using an SDK that doesn't have the right toolchain version, this seems save to do. (The motivation is that I want to move ANDROID_SDK_VERSION out of envsetup and into common.gypi.) This reverts part of https://chromiumcodereview.appspot.com/10920094 BUG=330631 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 10 months ago (2014-02-01 20:00:03 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-02-03 10:42:34 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-03 11:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/152173002/1
6 years, 10 months ago (2014-02-03 11:25:54 UTC) #4
commit-bot: I haz the power
Change committed as 248483
6 years, 10 months ago (2014-02-03 14:02:38 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 14:02:40 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 14:02:44 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698