Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1521703003: clang/win: Fix build after https://codereview.chromium.org/1456663003 (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
chromium-reviews, rickyz+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix build after https://codereview.chromium.org/1456663003 Fixes: ..\..\sandbox\win\src\sandbox_policy_base.cc(165,5) : error: delete called on 'sandbox::PolicyBase' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete this; ^ BUG=82385 R=rickyz@chromium.org TBR=wfh Committed: https://chromium.googlesource.com/chromium/src/+/d7d44840e9d3cd750eee01183b5a7834c9961e5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/win/src/sandbox_policy_base.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
5 years ago (2015-12-12 14:12:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521703003/1
5 years ago (2015-12-12 14:12:32 UTC) #5
rickyz (no longer on Chrome)
lgtm, thanks for the fix!
5 years ago (2015-12-12 14:24:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7d44840e9d3cd750eee01183b5a7834c9961e5e Cr-Commit-Position: refs/heads/master@{#364933}
5 years ago (2015-12-12 14:36:31 UTC) #10
Nico
5 years ago (2015-12-12 14:37:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7d44840e9d3cd750eee01183b5a7834c9961e5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698