packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart - Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « packages/charted/lib/charts/data_transformers/transpose_transformer.dart ('k') | packages/charted/lib/charts/layout_renderers/pie_chart_renderer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart

diff --git a/packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart b/packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart

index 2ebac9c71367b2f6b26e06125091be619b5a1aea..35bfbcc410a643eb687246ce26e86a68478be36a 100644

--- a/packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart

+++ b/packages/charted/lib/charts/layout_renderers/layout_base_renderer.dart

@@ -117,14 +117,13 @@ abstract class LayoutRendererBase implements LayoutRenderer {

}

- Iterable<String> stylesForValue(int row, { bool isTail: false }) {

- if (isTail == true) return const[];

+ Iterable<String> stylesForValue(int row, {bool isTail: false}) {

+ if (isTail == true) return const [];

if (_valueStylesCache[row] == null) {

if (state == null) {

- _valueStylesCache[row] = const[];

+ _valueStylesCache[row] = const [];

} else {

- var styles = [],

- flags = _valueStateCache[row];

+ var styles = [], flags = _valueStateCache[row];

if (flags & ChartState.VAL_HIGHLIGHTED != 0) {

styles.add(ChartState.VAL_HIGHLIGHTED_CLASS);