packages/smoke/lib/codegen/recorder.dart - Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/smoke/lib/codegen/recorder.dart

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: packages/smoke/lib/codegen/recorder.dart

diff --git a/packages/smoke/lib/codegen/recorder.dart b/packages/smoke/lib/codegen/recorder.dart

index 545455a0f7af7c1ba88eb6635297ba8c5259a52e..8a9ebf1323891c1ebeb38e6ce9397d78e32a5352 100644

--- a/packages/smoke/lib/codegen/recorder.dart

+++ b/packages/smoke/lib/codegen/recorder.dart

@@ -253,7 +253,7 @@ class Recorder {

/// Copy metadata associated with the declaration of [target].

List<ConstExpression> _copyAnnotations(Element target) {

- var node = target.node;

+ var node = target.computeNode();

// [node] is the initialization expression, we walk up to get to the actual

// member declaration where the metadata is attached to.

while (node is! ClassMember) node = node.parent;

« no previous file with comments | « packages/smoke/CHANGELOG.md ('k') | packages/smoke/lib/mirrors.dart » ('j') | no next file with comments »