Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: packages/dart_style/test/splitting/list_arguments.stmt

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/dart_style/test/splitting/invocations.stmt ('k') | packages/dart_style/test/splitting/loops.stmt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/dart_style/test/splitting/list_arguments.stmt
diff --git a/packages/dart_style/test/splitting/list_arguments.stmt b/packages/dart_style/test/splitting/list_arguments.stmt
index 8a2b17a88bb1c710c78c071aac85933dbf8bdaf9..ac10cc1ce785ec640d2eccc1a4fd7f6fa44e5396 100644
--- a/packages/dart_style/test/splitting/list_arguments.stmt
+++ b/packages/dart_style/test/splitting/list_arguments.stmt
@@ -273,10 +273,35 @@ longFunctionName([
element,
element
]);
->>> nest trailing named if there are non-body named
-longFunctionName(a: argument, b: argument,
+>>> allow leading non-collection to not split
+longFunctionName(a: arg, b: arg,
c: [element, element, element, element], d: [element, element, element, element]);
<<<
+longFunctionName(a: arg, b: arg, c: [
+ element,
+ element,
+ element,
+ element
+], d: [
+ element,
+ element,
+ element,
+ element
+]);
+>>> don't allow splitting before first arg while splitting collections
+longFunctionName(
+ a: argument, b: argument, c: [
+ element,
+ element,
+ element,
+ element
+], d: [
+ element,
+ element,
+ element,
+ element
+]);
+<<<
longFunctionName(
a: argument,
b: argument,
@@ -292,6 +317,41 @@ longFunctionName(
element,
element
]);
+>>> trailing named arguments that do not split
+longFunctionName(a: [element, element, element, element],
+b: [element, element, element, element], c: argument, d: argument);
+<<<
+longFunctionName(a: [
+ element,
+ element,
+ element,
+ element
+], b: [
+ element,
+ element,
+ element,
+ element
+], c: argument, d: argument);
+>>> trailing named arguments that do split
+longFunctionName(a: [element, element, element, element],
+b: [element, element, element, element], c: argument, d: argument, e: argument);
+<<<
+longFunctionName(
+ a: [
+ element,
+ element,
+ element,
+ element
+ ],
+ b: [
+ element,
+ element,
+ element,
+ element
+ ],
+ c: argument,
+ d: argument,
+ e: argument);
>>> leading named arguments
longFunctionName(name1: [element, element], name2: [element, element], name3: argument, name4: argument);
<<<
@@ -339,4 +399,39 @@ obj.outer(
element,
element,
element
- ]));
+ ]));
+>>> leading positional collections indent if their args split
+function([[element]],
+[[element]], argument, // comment
+argument);
+<<<
+function(
+ [
+ [element]
+ ],
+ [
+ [element]
+ ],
+ argument, // comment
+ argument);
+>>> trailing positional collections indent if their args split
+function(argument, // comment
+argument, [[element]], [[element]]);
+<<<
+function(
+ argument, // comment
+ argument,
+ [
+ [element]
+ ],
+ [
+ [element]
+ ]);
+>>> comment before collection
+function(argument, // comment
+[[element]]);
+<<<
+function(argument, // comment
+ [
+ [element]
+ ]);
« no previous file with comments | « packages/dart_style/test/splitting/invocations.stmt ('k') | packages/dart_style/test/splitting/loops.stmt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698