Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart
diff --git a/packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart b/packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart
index 08d89176bf124e560d17a554e9964c583005fa7e..96873bddea4f2c5a17e5fabcc8bc08dd01c784af 100644
--- a/packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart
+++ b/packages/charted/lib/charts/cartesian_renderers/cartesian_base_renderer.dart
@@ -1,10 +1,10 @@
-/**
- * Copyright 2014 Google Inc. All rights reserved.
- *
- * Use of this source code is governed by a BSD-style
- * license that can be found in the LICENSE file or at
- * https://developers.google.com/open-source/licenses/bsd
- */
+//
+// Copyright 2014 Google Inc. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file or at
+// https://developers.google.com/open-source/licenses/bsd
+//
part of charted.charts;
@@ -20,9 +20,9 @@ abstract class CartesianRendererBase implements CartesianRenderer {
List<int> _columnStateCache;
List<Iterable<String>> _columnStylesCache;
- final _valueColorCache = new Map<int,String>();
- final _valueFilterCache = new Map<int,String>();
- final _valueStylesCache = new Map<int,Iterable<String>>();
+ final _valueColorCache = new Map<int, String>();
+ final _valueFilterCache = new Map<int, String>();
+ final _valueStylesCache = new Map<int, Iterable<String>>();
Element host;
Selection root;
@@ -103,13 +103,10 @@ abstract class CartesianRendererBase implements CartesianRenderer {
@override
Extent extentForRow(Iterable row) {
assert(series != null && area != null);
- var measures = series.measures,
- max = SMALL_INT_MIN,
- min = SMALL_INT_MAX;
+ var measures = series.measures, max = SMALL_INT_MIN, min = SMALL_INT_MAX;
- for (int i = 0, len = measures.length; i < len; ++i) {
- var measure = measures.elementAt(i),
- value = row.elementAt(measure);
+ for (int i = 0, len = measures.length; i < len; ++i) {
+ var measure = measures.elementAt(i), value = row.elementAt(measure);
if (value != null && value.isFinite) {
if (value > max) {
max = value;
@@ -183,14 +180,13 @@ abstract class CartesianRendererBase implements CartesianRenderer {
Iterable<String> stylesForColumn(int column) {
if (_columnStylesCache[column] == null) {
if (state == null || area.useRowColoring) {
- _columnStylesCache[column] = const[];
+ _columnStylesCache[column] = const [];
} else {
- var styles = [],
- flags = _columnStateCache[column];
+ var styles = [], flags = _columnStateCache[column];
if (flags & ChartState.COL_SELECTED != 0) {
styles.add(ChartState.COL_SELECTED_CLASS);
- } else if (flags & ChartState.COL_UNSELECTED != 0){
+ } else if (flags & ChartState.COL_UNSELECTED != 0) {
styles.add(ChartState.COL_UNSELECTED_CLASS);
}
@@ -226,7 +222,7 @@ abstract class CartesianRendererBase implements CartesianRenderer {
var hash = hash2(column, row);
if (_valueStylesCache[hash] == null) {
if (state == null) {
- _valueStylesCache[hash] = const[];
+ _valueStylesCache[hash] = const [];
} else {
var styles = stylesForColumn(column).toList();
if (state.highlights.isNotEmpty) {
@@ -268,8 +264,8 @@ abstract class CartesianRendererBase implements CartesianRenderer {
var flags = _columnStateCache[column];
if (state.highlights.isNotEmpty) {
flags |= (state.highlights.any((x) => x.last == row)
- ? ChartState.VAL_HIGHLIGHTED
- : ChartState.VAL_UNHIGHLIGHTED);
+ ? ChartState.VAL_HIGHLIGHTED
+ : ChartState.VAL_UNHIGHLIGHTED);
}
if (state.hovered != null && state.hovered.last == row) {
flags |= ChartState.VAL_HOVERED;

Powered by Google App Engine
This is Rietveld 408576698