packages/observe/lib/src/observable_list.dart - Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/observe/lib/src/observable_list.dart

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: packages/observe/lib/src/observable_list.dart

diff --git a/packages/observe/lib/src/observable_list.dart b/packages/observe/lib/src/observable_list.dart

index 912c4fc2a3ec1af0c04981671ac1c216041031c8..9d09b38d560b43844f98b40f7d2ea2ff44a28cdd 100644

--- a/packages/observe/lib/src/observable_list.dart

+++ b/packages/observe/lib/src/observable_list.dart

@@ -91,7 +91,7 @@ class ObservableList<E> extends ListBase<E> with ChangeNotifier {

@reflectable void operator []=(int index, E value) {

var oldValue = _list[index];

- if (hasListObservers) {

+ if (hasListObservers && oldValue != value) {

_recordChange(new ListChangeRecord(this, index, addedCount: 1,

removed: [oldValue]));

}

« no previous file with comments | « packages/observe/CHANGELOG.md ('k') | packages/observe/pubspec.yaml » ('j') | no next file with comments »