packages/smoke/lib/static.dart - Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/smoke/lib/static.dart

Issue 1521693002: Roll Observatory deps (charted -> ^0.3.0) (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/observatory_pub_packages.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: packages/smoke/lib/static.dart

diff --git a/packages/smoke/lib/static.dart b/packages/smoke/lib/static.dart

index aad1542c46845084f1e40bdb6f9583896dfd7eba..2b5d065308c6b873580a3b79e5c4d241aebe81db 100644

--- a/packages/smoke/lib/static.dart

+++ b/packages/smoke/lib/static.dart

@@ -145,7 +145,7 @@ class GeneratedObjectAccessorService implements ObjectAccessorService {

}

try {

return Function.apply(method, args);

- } on NoSuchMethodError catch (e) {

+ } on NoSuchMethodError catch (_) {

// TODO(sigmund): consider whether this should just be in a logger or if

// we should wrap `e` as a new exception (what's the best way to let users

// know about this tentativeError?)

« no previous file with comments | « packages/smoke/lib/mirrors.dart ('k') | packages/smoke/pubspec.yaml » ('j') | no next file with comments »