Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1521673002: In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255. (Closed)

Created:
5 years ago by dogben
Modified:
5 years ago
Reviewers:
hal.canary, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255. Add a test that we get the same color back after calling SkBitmap::eraseColor, modulo rounding. Also update some incorrect docs. BUG=skia:4297 Committed: https://skia.googlesource.com/skia/+/a1bb8e02fe7956b2f85a0afadbca5f607a804403

Patch Set 1 #

Patch Set 2 : Wrap long line. #

Patch Set 3 : Make uppercase consistent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M include/core/SkCanvas.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPixmap.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M tests/BitmapTest.cpp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521673002/1
5 years ago (2015-12-11 20:54:37 UTC) #2
dogben
5 years ago (2015-12-11 21:11:47 UTC) #4
reed1
lgtm
5 years ago (2015-12-11 21:48:58 UTC) #6
mtklein
lgtm
5 years ago (2015-12-11 21:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521673002/40001
5 years ago (2015-12-11 21:53:16 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-11 22:09:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a1bb8e02fe7956b2f85a0afadbca5f607a804403

Powered by Google App Engine
This is Rietveld 408576698