Remove remaing deprecated API calls from cctest

Remove remaing deprecated API calls from cctest

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/716eb14aec062d8a439f67affa1c35b0a81125cf
Cr-Commit-Position: refs/heads/master@{#32809}

[vogelheim, 2015-12-11 15:19:03]

lgtm.

\o/ (Only nitpicks, feel free to ignore.)

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#old...
test/cctest/test-api.cc:15008: TEST(ForceSet) {
Well, this is a rather pragmatic solution. :)

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#new...
test/cctest/test-api.cc:17375:
CcTest::isolate()->VisitExternalResources(&visitor);
CcTest::isolate() -> isolate

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#new...
test/cctest/test-api.cc:21281: .IsNothing());
Why does this CHECK(... IsNothing)?

(I trust it's the correct choice, but I guess I just don't understand what the
test tries to accomplish.)

[jochen (gone - plz use gerrit), 2015-12-11 15:27:41]

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#old...
test/cctest/test-api.cc:15008: TEST(ForceSet) {
On 2015/12/11 at 15:19:03, vogelheim wrote:
> Well, this is a rather pragmatic solution. :)

:)

The test is testing that ForceSet breaks the object model...

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#new...
test/cctest/test-api.cc:17375:
CcTest::isolate()->VisitExternalResources(&visitor);
On 2015/12/11 at 15:19:03, vogelheim wrote:
> CcTest::isolate() -> isolate

done

https://codereview.chromium.org/1521593002/diff/1/test/cctest/test-api.cc#new...
test/cctest/test-api.cc:21281: .IsNothing());
On 2015/12/11 at 15:19:03, vogelheim wrote:
> Why does this CHECK(... IsNothing)?
> 
> (I trust it's the correct choice, but I guess I just don't understand what the
test tries to accomplish.)

it's part of a test that installs an access checked object where the access
check throws an exception. This particular function test that an access via the
C++ API also throws.

[jochen (gone - plz use gerrit), 2015-12-11 15:28:05]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-11 15:28:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1521593002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2015-12-11 15:28:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1521593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1521593002/20001

[commit-bot: I haz the power, 2015-12-11 16:14:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-11 16:15:26]

Description was changed from

==========
Remove remaing deprecated API calls from cctest

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n
==========

to

==========
Remove remaing deprecated API calls from cctest

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/716eb14aec062d8a439f67affa1c35b0a81125cf
Cr-Commit-Position: refs/heads/master@{#32809}
==========

[commit-bot: I haz the power, 2015-12-11 16:15:27]

Patchset 2 (id:??) landed as
https://crrev.com/716eb14aec062d8a439f67affa1c35b0a81125cf
Cr-Commit-Position: refs/heads/master@{#32809}