Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1521583002: Oilpan: fix build after r364654. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r364654. TBR=oilpan-reviews BUG=531990 NOTRY=true Committed: https://crrev.com/541f3f6dc974673998ba38cfb14d7b0d4b4c6fd6 Cr-Commit-Position: refs/heads/master@{#364678}

Patch Set 1 #

Patch Set 2 : no need for GarbageCollectedFinalized<> for SlotAssignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sof
minor detail not taken care of by a larger CL, otherwise good.
5 years ago (2015-12-11 12:18:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521583002/20001
5 years ago (2015-12-11 12:19:32 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 12:24:02 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/541f3f6dc974673998ba38cfb14d7b0d4b4c6fd6 Cr-Commit-Position: refs/heads/master@{#364678}
5 years ago (2015-12-11 12:25:05 UTC) #6
haraken
LGTM
5 years ago (2015-12-11 12:47:43 UTC) #7
hayato
Thank you for fixing this. I appreciate that. The reason that we can not use ...
5 years ago (2015-12-14 02:16:16 UTC) #8
haraken
5 years ago (2015-12-14 02:17:22 UTC) #9
Message was sent while issue was closed. 
On 2015/12/14 02:16:16, hayato wrote:
> Thank you for fixing this. I appreciate that.
> 
> The reason that we can not use OwnPtr<SlotAssignment> is that SlotAssignment
has
> m_assignment, which is Oilpan's *Member*, right?

Right.

Powered by Google App Engine
This is Rietveld 408576698