Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: src/heap/mark-compact.h

Issue 1521573002: [heap] Remove SweeperType and clean up SweepSpace a bit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index e83dcfb898f3a4d7347b59bdca591a8dfc2b44d6..95f2e09d066a2d653c37e43d1f7764944d241a87 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -365,11 +365,6 @@ class MarkCompactCollector {
CodeFlusher* code_flusher() { return code_flusher_; }
inline bool is_code_flushing_enabled() const { return code_flusher_ != NULL; }
- enum SweeperType {
- CONCURRENT_SWEEPING,
- SEQUENTIAL_SWEEPING
- };
-
enum SweepingParallelism { SWEEP_ON_MAIN_THREAD, SWEEP_IN_PARALLEL };
#ifdef VERIFY_HEAP
@@ -693,7 +688,6 @@ class MarkCompactCollector {
// regions to each space's free list.
void SweepSpaces();
-
void EvacuateNewSpace();
void AddEvacuationSlotsBufferSynchronized(
@@ -731,7 +725,9 @@ class MarkCompactCollector {
// corresponding space pages list.
void MoveEvacuationCandidatesToEndOfPagesList();
- void SweepSpace(PagedSpace* space, SweeperType sweeper);
+ // Starts sweeping of a space by contributing on the main thread and setting
+ // up other pages for sweeping.
+ void StartSweepSpace(PagedSpace* space);
// Finalizes the parallel sweeping phase. Marks all the pages that were
// swept in parallel.
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698