Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java

Issue 1521553004: Fix three crashes in the recent tabs dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java
index 04b5f5a17ffe23171f4f64ea31e95f57c7853763..48d8bfa77c524dd33045daa804d10a8fb45c0dde 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java
@@ -116,6 +116,7 @@ public class DocumentRecentTabsManager extends RecentTabsManager {
ThreadUtils.postOnUiThreadDelayed(new Runnable() {
@Override
public void run() {
+ if (isDestroyed()) return;
DocumentRecentTabsManager.super.openForeignSessionTab(
session, tab, WindowOpenDisposition.NEW_FOREGROUND_TAB);
if (mDialog != null) mDialog.dismiss();
@@ -131,6 +132,7 @@ public class DocumentRecentTabsManager extends RecentTabsManager {
ThreadUtils.postOnUiThreadDelayed(new Runnable() {
@Override
public void run() {
+ if (isDestroyed()) return;
DocumentRecentTabsManager.super.openRecentlyClosedTab(
tab, WindowOpenDisposition.NEW_FOREGROUND_TAB);
if (mDialog != null) mDialog.dismiss();
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698