Issue 1521543002: Fix a regression for parsing '/' - commit a568ff2d was too strict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1521543002: Fix a regression for parsing '/' - commit a568ff2d was too strict. (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
David Lattimore

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

David Lattimore

lgtm FYI I found another file similarly affected. This change fixes it as well. I ...

5 years ago (2015-12-11 06:11:41 UTC) #3

Lei Zhang

BTW, this reintroduces the leak that I was trying to fix. I guess I will ...

5 years ago (2015-12-12 03:00:57 UTC) #4

Lei Zhang

5 years ago (2015-12-12 03:01:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ebc7695c60fc3e4afbfa6d9db162a71b190bf685 (presubmit successful).